Battle of Backbone Mountain

Military history Template‑class

This template is within the scope of the Military history WikiProject. If you would like to participate, please visit the project page, where you can join the project and see a list of open tasks. To use this banner, please see the full instructions.Military historyWikipedia:WikiProject Military historyTemplate:WikiProject Military historymilitary history articles Template This template does not require a rating on the project's quality scale.

Archives

Index Archive 1 Archive 2

This page has archives. Sections older than 90 days may be automatically archived by Lowercase sigmabot III when more than 5 sections are present.

In Template:WikiProject Military history the parm "TF_14_NESTED = Weaponry" is duplicated, giving an error. The 2nd one should be removed. Davemck (talk) 15:16, 16 December 2023 (UTC)[reply]

 Done SWinxy (talk) 19:09, 16 December 2023 (UTC)[reply]

This template uses "disambig" for disambiguation pages but some other projects are using "disambiguation". This causes some editors to enter "disambiguation" instead of "disambig" eg Talk:Battle of Tallinn, Talk:German occupation of Estonia, Talk:Partisans in the Baltic States. How hard would it be to have our template accept both? Hawkeye7 (discuss) 00:40, 9 January 2024 (UTC)[reply]

It's a discrepancy between how Template:WikiProject Military history/Class works and how Template:WPBannerMeta and its modules work.

The former has two lines like this:

|dab|disambig=DAB

which respects the values dab and disambig (case-insensitive).

The latter respects the values disambiguation, disambig and dab (again case-insensitive), and have done for some years; more recently, they have been amended to autodetect that the subject page is a disambiguation page, but I'm not sure if it's done by looking for a template tag like {{disambig}} or the presence of the page in Category:Disambiguation pages or its subcats.

It should be noted that Template:WikiProject Military history is now built around Template:WPBannerMeta and so using |class=disambiguation will cause a mixture of effects. I shall elaborate if asked. --Redrose64 🌹 (talk) 09:38, 9 January 2024 (UTC)[reply]

Module:WikiProject banner calls Module:Class mask which in turn calls Module:Disambiguation. That module checks the article's content for the presence of disambiguation templates calls (comparing against the list at Module:Disambiguation/templates). This means that in most disambiguation articles, WikiProject banners using standard quality assessments ignores the class parameter entirely. Harryboyles 16:04, 9 January 2024 (UTC)[reply]

Since Template:WikiProject Military history is built around Template:WPBannerMeta does Template:WikiProject Military history/Class need to process disambiguation pages or can it be left to the default? Hawkeye7 (discuss) 20:39, 9 January 2024 (UTC)[reply]

Does anyone know how articles wind up in Category:Military history articles needing attention to tagging? I've looked at a couple and cannot see anything wrong with them. Hawkeye7 (discuss) 03:37, 10 January 2024 (UTC)[reply]

The articles get put into this category if the {{WikiProject Military history}} call includes the A-Class parameter and either:

1. There hasn't actually been an A-class review started (i.e. Wikipedia:WikiProject Military history/Assessment/**Name of nominated article** doesn't exist).
2. The value of the A-Class parameter isn't one of pass|keep|kept|fail|demote|demoted|current (most commonly |A-Class=no)

There were two pages which did have an A-class assessment subpage, but the category hadn't refreshed. Per step 7 of the instructions at Wikipedia:WikiProject_Military_history/Assessment/A-Class_review, a null edit cleared the category from these two pages. Harryboyles 08:01, 10 January 2024 (UTC)[reply]

I've just added some explanation to Category:Military history articles needing attention to tagging Harryboyles 08:12, 10 January 2024 (UTC)[reply]

I think they all have A-Class assessment subpages. What has happened is that the article was renamed after the A-Class review. This is noted in the ArticleHistory. Do we need to create redirects to remove the articles from the category? Or can it be made smarter? Is it possible to inform the the template? Hawkeye7 (discuss) 21:42, 10 January 2024 (UTC)[reply]

Redirect is probably the simplest fix - just created a redirect: Wikipedia:WikiProject Military history/Assessment/57th Rifle Division -> Wikipedia:WikiProject Military history/Assessment/57th Rifle Division (Soviet Union). Doing a null edit on Talk:57th_Rifle_Division afterwards cleared the category. Harryboyles 06:37, 11 January 2024 (UTC)[reply]

These articles are listed as being incorrectly assessed as articles instead of lists, but class=list. Looks like a problem with the template. Hawkeye7 (discuss) 23:25, 16 January 2024 (UTC)[reply]

According to the template documentation, |list=yes is required to be added as a parameter in order to apply the list-based assessment criteria. Harryboyles 08:27, 17 January 2024 (UTC)[reply]

What progress are we making on getting Template:WikiProject Military history to get it to inherit from Template:WikiProject banner shell? Seems to be a lot of unecessary bot work going on just dealing with this. Hawkeye7 (discuss) 20:15, 17 January 2024 (UTC)[reply]

@Harryboyles: Looking at Talk:Ironclad warship, the WikiProject Banner Shell is set to C class, but this is not being inherited by the WikiProject Military history banner, which for some bizarre reason is showing the article as Start class, although there is no class parameter. This causes weird effects, with the article being categorised as both C and Start class. Any idea where the start comes from? And how we can get the banner to inherit correctly? Hawkeye7 (discuss) 22:23, 31 March 2024 (UTC)[reply]

From the template page: WikiProject Military history has opted out of project-independent quality assessments and is using a custom class mask. With the article being recently demoted from A-class, the automatic class rating from the class mask applies. There's no B-Class assessment checklist done (B-Class-1 through B-Class-5 parameters), so the default case of Start-class applies. Wikipedia:WikiProject Military history/Assessment#Criteria lists the criteria required for C-class (The article meets B1 or B2 as well as B3 and B4 and B5 of the B-Class criteria.) and B-class (The article meets all of the B-Class criteria.) Harryboyles 23:03, 31 March 2024 (UTC)[reply]

If there is no B-Class assessment checklist done, then the article should be in Category:Military history articles with missing B-Class checklists. The bot will then assess it. I don't know why it is not. The default is for unassessed articles is to be placed in Category:Unassessed military history articles. WikiProject Military history has not opted out of quality assessments. I will see if we can get that message corrected. Hawkeye7 (discuss) 23:57, 31 March 2024 (UTC)[reply]

@Hawkeye7: Harryboyles didn't say that milhist had opted out of quality assessments; they said WikiProject Military history has opted out of project-independent quality assessments, please note the qualifier "project-independent" here. Quality assessments still occur, but need to be set on the milhist banner as well as on the banner shell. --Redrose64 🌹 (talk) 05:57, 1 April 2024 (UTC)[reply]

The project should inherit the rating from the banner shell where it is set. Hawkeye7 (discuss) 07:03, 1 April 2024 (UTC)[reply]

@Redrose64: When QUALITY_CRITERIA=='custom' and there is no class set, the module is supposed to "replace class with inherited class". Hawkeye7 (discuss) 07:45, 1 April 2024 (UTC)[reply]

if args.QUALITY_CRITERIA=='custom' then -- project has opted out of standard assessment scale and uses a custom mask
		local custom_mask = banner_name:subPageTitle('class')
		if custom_mask.exists and #custom_mask:getContent()>1 then
			raw_args.demo_page = args.demo_page -- send demo_page to custom mask
			class = mw.text.trim(frame:expandTemplate{
				title = custom_mask.prefixedText,
				args = raw_args
			})
			if class=='' and article_class and article_class~='' then -- if unassessed and article class exists, check if it can be inherited
				local new_arg_table = {}
				for arg, val in pairs(raw_args) do -- construct new argument table to send to custom mask
					new_arg_table[arg] = val
				end
				new_arg_table.class = article_class -- replace class with inherited class
				local article_class_normalised = mw.text.trim(frame:expandTemplate{
					title = custom_mask.prefixedText,
					args = new_arg_table
				})
				if article_class_normalised and article_class_normalised~='' then
					class = article_class_normalised -- inherit class from article_class normalised by custom mask
				else
					article_class = nil -- effectively no article_class for this banner
				end
			end
		end
}}

Hawkeye7 (discuss) 07:45, 1 April 2024 (UTC)[reply]

Military history articles must never default to start class. Hawkeye7 (discuss) 07:29, 1 April 2024 (UTC)[reply]